ggsignif icon indicating copy to clipboard operation
ggsignif copied to clipboard

feature request: multiple testing correction

Open andreasleha opened this issue 7 years ago • 7 comments

If I do not miss anything, there is currently no way to include a multiple comparison correction. This would be a very useful addition.

andreasleha avatar Aug 08 '17 19:08 andreasleha

Yes, I agree this would indeed be a useful feature. I am not quite sure what would be the best default (Bonferroni, Holm, Benjamini-Hochberg, None?), but adding the possibility for the use to choose any of those makes sense. Unfortunately I am quite busy right now, so I am not sure when I will have time to implement the feature. Of course if you would be interested in trying, I could give you some pointers where to start.

const-ae avatar Aug 09 '17 09:08 const-ae

I just submitted a pull request with this functionality quickly added - for BH/fdr only. Prior to merging you can try it out here: https://github.com/sidderb/ggsignif

sidderb avatar Sep 12 '17 15:09 sidderb

ggsignif works very nicely and is incredibly useful with facet_wrap. If the BH/FDR option could recognize the number of facets and correct accordingly, that would be great !

jchellmuth avatar Aug 07 '18 00:08 jchellmuth

I would also have great use for multiple testing option-

antagomir avatar Sep 04 '18 08:09 antagomir

+1 for this feature. Thanks for the package, btw!

iferres avatar Jan 19 '22 17:01 iferres

Was this feature added? If so, where do I find how to use it? Otherwise, is there another way to use e.g. pairwise.wilcox.test as the test? Many thanks.

TahelRonel avatar Aug 25 '23 11:08 TahelRonel

I've incorporated sidderb FDR functionality to the newest version of ggsignif. Please find at ggsignif-FDR

elnaggarj avatar Sep 04 '23 01:09 elnaggarj