quickbooks-php
quickbooks-php copied to clipboard
consolibyte
Remove QuickBooks/QBXML/Schema/Object/tmp dir that is gitignored.
The .gitignore file ignores tmp/ https://github.com/consolibyte/quickbooks-php/blob/master/.gitignore#L9
Yet several files under QuickBooks/QBXML/Schema/Object/tmp still exist since initial commit and have been untouched since then. https://github.com/consolibyte/quickbooks-php/commits/master/QuickBooks/QBXML/Schema/Object/tmp
It seems to me this is a mistake because these files all seem to have equivalents in QuickBooks/QBXML/Schema/Object that have been worked on since.
I assume the stuff under tmp was a pre-git snapshot of an earlier state of these files? As far as I can tell it is just junk at this point, but I could be wrong.
I discovered this after using composer to pull in consolibyte/quickbooks, then committing everything to my project's repo. When I returned to another branch on my project, these files were left hanging. They had not committed to my repo because of your gitignore.
This pull request is still Open, and there has been no comment. Do you disagree with my assessment that these files are just old unused cruft? Thank you.
This pull request is still Open, and there has been no comment. Do you disagree with my assessment that these files are just old unused cruft? Thank you.