Leaflet.HtmlLegend icon indicating copy to clipboard operation
Leaflet.HtmlLegend copied to clipboard

Multiple changes for the next release (0.4.0)

Open ka7eh opened this issue 5 years ago • 5 comments

Apply the following changes:

  • Add allowRemove option for legends
  • Move disableVisibilityControls from control options to legend options
  • Fix an issue caused by missing html key in legend elements props

@nikmolnar looks like I don't have write access to this repo. Do you mind reviewing this PR and creating a new release for it? Thanks.

ka7eh avatar Jan 12 '20 04:01 ka7eh

Looks good to me.

brentfraser avatar Jan 13 '20 16:01 brentfraser

Any updates on when these changes will be released? Particularly interested #10.

joffreyj avatar Feb 11 '20 16:02 joffreyj

I'll try to release a new version on npm today or tomorrow. @nikmolnar can you give me write access to this repo so I can merge the PR to master?

ka7eh avatar Feb 11 '20 16:02 ka7eh

@joffreyj I published a new version to npm. I'll merge the PR into master too as soon as I get write access to the repo.

ka7eh avatar Feb 13 '20 00:02 ka7eh

Go a chance to pull this down and look at it... not exactly what I was talking about... I was hoping to be able to remove the map and all from menu.

I would like for the user to be able to remove the entry from the legend altogether. I hope the screen shot clears this up, I do want to thank you for your time you put into this.

On Wed, Feb 12, 2020 at 6:03 PM Kaveh [email protected] wrote:

@joffreyj https://github.com/joffreyj I published a new version to npm. I'll merge the PR into master too as soon as I get write access to the repo.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/consbio/Leaflet.HtmlLegend/pull/13?email_source=notifications&email_token=ABSNR3G7NEV5O7PEXZFCVKDRCSE5TA5CNFSM4KFVT232YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELS3S4Y#issuecomment-585480563, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSNR3G3EIVELX6G3JGHUFTRCSE5TANCNFSM4KFVT23Q .

-- Geoffrey Joseph | Enterprise Web Developer IT Services University of Arkansas at Little Rock 501.916.3010 | [email protected] | ualr.edu

joffreyj avatar Feb 13 '20 16:02 joffreyj