Conrado Gouvea

Results 42 comments of Conrado Gouvea

> I've edited the ticket description to use `with_failure_regex_iter` - we didn't have that test harness feature when we added mempool support to `sync_until`. Thanks!

Note that we wanted to move proof decoding inside tx deserialization: https://github.com/ZcashFoundation/zebra/issues/3179 I don't think this changes anything since the proposed approach in this ticket is probably easier, but I...

Yep we need to decide which approach to use: - Leave the byte array, and decode inside the batch verifier, as suggested in the ticket - Replace the byte array,...

This was blocked by zcashd dependencies being updated, but 5.1.0 was released 3 days ago, we can now update zcash_script and remove these https://github.com/ZcashFoundation/zebra/blob/c4f89ed2e1942fe9c484d574f8a66df8e49953bb/deny.toml#L34-L38 The last one is caused by...

Here's a graph (dot file) I generated to help me understand the dependencies between services (this is how it looks like after https://github.com/ZcashFoundation/zebra/pull/2741), and that we could add to the...

> This is awesome! I wonder if we can do a service dependency diagram at a similar high level automatically derived from the codebase, so that we can keep it...

I wonder if [some of these suggestions](https://github.com/facebook/rocksdb/wiki/Speed-Up-DB-Open) can also reduce the opening time

> Lock times are only enabled if there is at least one sequence number that is `u32::MAX`. > There isn't really any need for a table, because the rules are:...

> Could this be related to #794 at all? I think it's not, the current value seems to follow the rules https://github.com/ZcashFoundation/zebra/blob/8120e8abac29d02c6df2db2c2b5bc666d2c657c0/zebra-network/src/constants.rs#L112 But we can double check.

Zecmate is showing Zebra nodes: https://explorer.zecmate.com/network ![image](https://user-images.githubusercontent.com/35766/140075409-92284605-b73b-4126-a2fe-40b707bdec41.png)