Conor Schaefer

Results 203 comments of Conor Schaefer

In order to handle an InitChain request, we must pass back an [InitChain response](https://docs.rs/tendermint/latest/tendermint/abci/response/struct.InitChain.html), which requires an app hash. To generate that app hash, we commit to storage, during which...

I wasn't able to get the fudged-hash approach working. Using the `[0u8; 32]` approach fails with an app hash mismatch from tendermint: > `Feb 07 08:58:14 Antigonus tendermint[260242]: E[2023-02-07|08:58:14.301] Error...

De-prioritized in favor of #1843; leaving research here for a later date. This problem isn't critical.

This problem reared its head again during Testnet 61, due to trouble peering (#3056). Would still be nice to have a solution to this one.

From current testnet: ``` ❯ curl -s http://localhost:9000/metrics | rg ^penumbra_stake | rg -v missed_blocks penumbra_stake_validators_inactive 363 penumbra_stake_validators_jailed -23 penumbra_stake_validators_disabled 29 penumbra_stake_validators_active 0 penumbra_stake_validators_defined 64 ``` There are a few...

Similarly, the missed blocks metric is not accurate: ``` ❯ curl -s http://localhost:9000/metrics | rg ^penumbra_stake_missed_blocks | sort -k 2 -n -r | head -n 20 penumbra_stake_missed_blocks{identity_key="penumbravalid14e54ukuppxs3f6dsg6flx9tsmqcv363tvvzrdku8fgmagjd435fqexu7zs"} 148359350 penumbra_stake_missed_blocks{identity_key="penumbravalid1u60u8405jg8mlz0epmhqfslqqkjurx6l4pm8n3j0ves66sztwqrqctw4f2"} 137059677...

> Ok I get why they're different, but not why those values are so high We should be computing `missed_blocks += n` but instead we're computing `missed_blocks += (missed_blocks +...

Took a closer look at this today. The `missed_blocks` issue is appears quite simple: the `increment` -> `set` fix discussed above should resolve. As for the validator state metrics, the...

> Should we be using metrics for this at all? [...] We already have a system for that, the event mechanism, and we should use it. This is a great...