Connor Peet
Connor Peet
Thanks for the PR! I pushed some small tidying. I think there's two more things we may want to do: 1. Apply the path mapping when converting a path to...
Hi, sorry for the late response. 1. For `sourceMapSourceToAbsolute`, I think we should do this. In your case, the debugger will see `node_modules/foo/index.js` is mapped to `node_modules/foo/index.ts` (referencing `./index.ts`) so...
Hi, I started merging this in https://github.com/microsoft/vscode-js-debug/tree/jchip-path-mappings. I don't think we need the changes to the breakpoint predictor and instead manage it by updating `absolutePathToUrlRegexp`. Let me know if it...
A workaround for you is to add `nodeVersionHint: 10` to your launch.json. A more correct fix would be to support nodenv in the [NvmResolver](https://github.com/microsoft/vscode-js-debug/blob/master/src/targets/node/nvmResolver.ts) (todo: should be refactored to be...
Fyi there was a bug in the binary provider, you'll need to use the [next nightly](https://github.com/microsoft/vscode-js-debug#nightly-extension) for the hint to work.
I like this idea and would find it quite handy myself. Implementing our own mechanism here (e.g. redefining properties or adding proxies) is not something I want to do since...
I repro'd this following the instructions on https://github.com/aspnet/AspNetCore-ManualTests/issues/284. In that case, a script that happened to be in `libs/RazorLib1/wwwroot/exampleJsInterop.js` was served directly in `http://localhost:5200/_content/RazorLib1/exampleJsInterop.js`. There's nothing for the debugger to...
This seems reasonable. Code pointer (in our upcoming debugger, currently in preview) if you or anyone else wants to put in a PR: https://github.com/microsoft/vscode-js-debug/blob/4b5cba447468cd60e949dd2d089b3608e38d5dc1/src/ui/configuration/nodeDebugConfigurationProvider.ts#L113 For bonus points, we could omit...
We would not be able to hook up "go to symbol" in general since as a debugger we have no such symbol registry. However, functions do give us that internal...