Connor Henderson

> Hey! You can also add `g2p` to the list of package needed to run the PR documentation tests in the CI job! Do you need help with that? >...

Hey @mollerup23 @sanchit-gandhi. Apologies, I'm not sure how picking these up works, I started working on it cause I saw there was no assignee and now have something I think...

Sounds good, thanks

> I think this was still a fix we were interesting in having for users who don't have `ftfy` installed. Oh ok reopening in that case

Thanks for your comments Arthur! Looking back at it to make your changes I realized two things: - we actually don't need to add the pattern splitting to the BasicTokenizer,...

Hey @ArthurZucker just checking in, anything else wanted here?

Update: just keeping this PR to the punc splitting param, reasoning below. Lmk if you have other thoughts! Wrote a [script](https://colab.research.google.com/drive/1tz4yZ_tHsGFvMlhQoihW4kCbCsxAGXco#scrollTo=bIaelmkHsWie) I ran locally to get a directional sense of...

>I think this proves that NFC is indeed a good addition which was previously missing ! Thanks and sounds good, I'll put it back in. I had removed it only...

Hey @Narsil just checking in, anything else wanted here?

Noticed the linked issue was marked stale, this PR probably will be soon too. Any other action wanted here? I think as the script shows this will significantly improve how...