vector icon indicating copy to clipboard operation
vector copied to clipboard

Confirmation patch

Open jakekidd opened this issue 4 years ago • 2 comments

The Problem

Nonce has expired, but sometimes takes longer than 45 sec to confirm. Results in a UI/UX issue - the tx eventually goes through, but our store/application state does not reflect it.

The Solution

Sledgehammer fix for issue where nonce expired, and we re-check for confirmation. Wait for an extended period when nonce has expired.

Also added some good juicy logs in there (and removed a redundant "Tx submitted." log)

jakekidd avatar Jun 11 '21 17:06 jakekidd

Can't repro the issues/failures in the CI for this. The only additional functionality I added was the additional argument for the waitForConfirmation. Any insight welcome

jakekidd avatar Jun 12 '21 19:06 jakekidd

Can't repro the issues/failures in the CI for this. The only additional functionality I added was the additional argument for the waitForConfirmation. Any insight welcome

Just wanted to let you know, waitForConfirmation didn't work at the frontEnd. I had to add tx.wait() to make things work.

sanchaymittal avatar Jun 14 '21 10:06 sanchaymittal