connectbot icon indicating copy to clipboard operation
connectbot copied to clipboard

Please add a light theme

Open wp9015362 opened this issue 9 years ago • 6 comments

Hello,

currently ConnectBot only has a dark theme.

Would there be any chance you could also add a light theme?

It would be much appreciated.

Regards

wp9015362 avatar Aug 30 '15 17:08 wp9015362

You can see some guidelines for a light theme in the Google Material Design guidelines over there:

https://www.google.com/design/spec/style/color.html#color-themes

Regards

wp9015362 avatar Aug 31 '15 05:08 wp9015362

PS:

When the light theme is in use, the FG and BG colors for the terminal should also be inverted by default of course. So, FG should be black and BG should be white.

Regards

wp9015362 avatar Aug 31 '15 05:08 wp9015362

Switching themes at runtime is problematic.

kruton avatar Sep 14 '15 17:09 kruton

@kruton wrote:

Switching themes at runtime is problematic.

Why?

There are several other (open source) apps which allow to switch between dark and light themes, like for example Amaze File Manager, TextSecure, spaRSS, Kore and probably many many more...

None of those have issues switching the theme while the app is running AFAICT.

You might want to have a look at Amaze File Manager, as the theme switching is working really nice in it.

Anyway, even if the theme switching would cause problems, which it obviously shouldn't as Amaze File Manager proves, then you could simply add a disclaimer to the option, which tells the user that this option requires a restart of the app and/or prompt the user to restart the app.

Regards

wp9015362 avatar Sep 14 '15 23:09 wp9015362

I've just implement a Light/Dark in one of my applications. I had problems using it before setContentView(). It seems preferable to use it before onCreate().

  protected void onCreate( Bundle savedInstanceState )
  {
    if(setup.useLightTheme())
      setTheme(R.style.AppTheme_Light);
    super.onCreate(savedInstanceState);
  }

alescdb avatar Sep 15 '15 11:09 alescdb

Any follow-ups for a light color theme?

On an e-ink device, dark background doesn't look right. I'm mainly talking about the main menu and settings menu, because the console itself can be set to light background anyway.

oldherl avatar Nov 12 '20 15:11 oldherl