James Mortemore

Results 61 comments of James Mortemore

Requires a slight refactor to implement. To see if Mojang fixes the client side issue or not before starting.

This pull request is becoming rather large now @velias when will it be in a ready state to review? 😄

Thanks @velias I'll set some time aside soon to review :)

Not yet @velias but thank you for the reminder 😄 Will get to it shortly

Yes, this is expected. The validation won't run in this case; as the name suggests it needs to be a unique name. Under the hood, this module auto generates a...

Hi @velias. Thanks for the suggestion. I'm not familiar with the validationRules option, could you enlighten me on what this would help achieve with this module? 🙂

@velias Overall it sounds ideal but doing some digging into this, it appears they do not have access to input values nor argument variables? There also appears to be a...

@velias open to seeing a PoC with this working 🙂

I can't see tests failing, only the code ;) You shouldn't be losing the `Title` type 🤔 Unfortunately the only way to achieve this library at the time was to...

The TypeScript definitions were added in #68, happy to accept a PR if they're not correct