schema-registry icon indicating copy to clipboard operation
schema-registry copied to clipboard

Adding support for tinyint values

Open vamossagar12 opened this issue 9 years ago • 6 comments

Based upon the theory provided in the official jdbc documentation, I have added a condition to include both Short and Byte as INT8 types in ConnectSchema.

Here's the doc:

8.3.5 SMALLINT

The JDBC type SMALLINT represents a 16-bit signed integer value between -32768 and 32767.

The corresponding SQL type, SMALLINT, is defined in SQL-92 and is supported by all the major databases. The SQL-92 standard leaves the precision of SMALLINT up to the implementation, but in practice, all the major databases support at least 16 bits.

The recommended Java mapping for the JDBC SMALLINT type is as a Java short. This would allow kafka-connect-jdbc to allow both signed and unsigned values. Currently it fails for unsigned values(i.e values > 127). The relevant PRs have been sent for kafka-connect-jdbc and kafka projects.

vamossagar12 avatar Oct 19 '16 14:10 vamossagar12

Can one of the admins verify this patch?

ConfluentJenkins avatar Oct 19 '16 14:10 ConfluentJenkins

It looks like @vamossagar12 hasn't signed our Contributor License Agreement, yet.

Appreciation of efforts,

clabot

ghost avatar Oct 19 '16 14:10 ghost

How do I sign the CLA? I don't see any links for the same.

vamossagar12 avatar Oct 19 '16 14:10 vamossagar12

Hi Any updates on this?

vamossagar12 avatar Oct 21 '16 15:10 vamossagar12

@vamossagar12 can you link some of the PR's for kafka-connect-jdbc and kafka. I just want to make sure I get a wholistic view of the change that you are trying to make. I do think that this might be a useful change but I just want to make sure that I'm not missing anything.

mageshn avatar Nov 09 '18 19:11 mageshn

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Rao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Sep 25 '23 16:09 cla-assistant[bot]