schema-registry icon indicating copy to clipboard operation
schema-registry copied to clipboard

Handle Optional Values within Records

Open SupermanScott opened this issue 10 years ago • 7 comments

Summary: This change allows for the use of optional fields, especially optional strings within a record. Prior to the change the only null check on value is in the public toConnectData method. This isn't sufficient when handling Avro Records. It is common to have a Record that has optional types within it.

SupermanScott avatar Mar 29 '16 18:03 SupermanScott

Can one of the admins verify this patch?

ConfluentJenkins avatar Mar 29 '16 18:03 ConfluentJenkins

It looks like @SupermanScott hasn't signed our Contributor License Agreement, yet.

Appreciation of efforts,

clabot

ghost avatar Mar 29 '16 19:03 ghost

Can one of the admins verify this patch?

ConfluentJenkins avatar Mar 29 '16 20:03 ConfluentJenkins

ok to test

ewencp avatar Apr 04 '16 03:04 ewencp

@SupermanScott Basic changes seem good, left a couple of minor comments and it looks like it needs a merge/rebase.

ewencp avatar Apr 04 '16 03:04 ewencp

@SupermanScott I can help take this PR forward. There are few rebase issues that need to be sorted out since this PR is old. Otherwise, we can just work a new PR against master. WDYT?

mageshn avatar Nov 09 '18 19:11 mageshn

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 6 committers have signed the CLA.

:x: Michael G. Noll
:x: ewencp
:x: alexlod
:x: gwenshap
:x: ijuma
:x: sdreynolds


Michael G. Noll seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Sep 25 '23 16:09 cla-assistant[bot]