Purge brokers no longer reported in metadata

[mfleming]

Brokers that are not in the metadata should be purged from the internal client lists. This helps to avoid annoying "No route to host" and other connection failure messages.

Fixes #238

[emasab]

Hi @mfleming can I apply those changes or do you want to continue the PR? Thanks!

[mfleming]

Hey sorry for the delay — yeah you can apply those changes if you have the time. If not I’ll get to them sometime this week.

On Tue, 21 May 2024 at 09:10, Emanuele Sabellico @.***> wrote:

Hi @mfleming https://github.com/mfleming can I apply those changes or do you want to continue the PR? Thanks!

— Reply to this email directly, view it on GitHub https://github.com/confluentinc/librdkafka/pull/4557#issuecomment-2122025277, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXALUEWS5XRZGGJX6EN43ZDL6QDAVCNFSM6AAAAABASEOCUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRSGAZDKMRXG4 . You are receiving this because you were mentioned.Message ID: @.***>

[emasab]

@mfleming thanks, sorry for the delay too, I'm checking it again

[emasab]

/sem-approve

[emasab]

/sem-approve

[emasab]

We're not going to merge this for 2.5.0 that is due in July as we need to do more checks on possible regressions but we want to merge it for a maintenance release in September

[mfleming]

We're not going to merge this for 2.5.0 that is due in July as we need to do more checks on possible regressions but we want to merge it for a maintenance release in September

Thanks for fixing things :)

[emasab]

Thanks for fixing things :)

Thank you for this PR!

[benesch]

Just wanted to say a big thank you to both of you—@mfleming for writing this and @emasab for reviewing. We just ran into a slow thread leak in a Kafka consumer at @MaterializeInc that will be fixed by this patch.