librdkafka icon indicating copy to clipboard operation
librdkafka copied to clipboard

Doc typo: rd_kafka_conf_destroy(rk) should be (conf)

Open Quuxplusone opened this issue 2 years ago • 3 comments

As mentioned in #4100.

Quuxplusone avatar Dec 16 '22 21:12 Quuxplusone

I've rebased the patch. We still haven't resolved what is the intended semantics of fail(...) in this example. Being a C++ chauvinist myself, I prefer to think of fail(...) as doing a throw or longjmp, so that we still need to clean up before calling it. That's also the most useful semantics for documentation purposes, because it gives us a chance to show the reader what they actually need to do to clean up after each of these calls. If we assume fail(...) means abort(), then we don't need to clean up (in this example) but we also can't show the reader what they need to do to clean up (in actual practice).

Quuxplusone avatar Jul 17 '23 13:07 Quuxplusone

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Aug 21 '23 15:08 cla-assistant[bot]

New year's ping!

Quuxplusone avatar Jan 11 '24 16:01 Quuxplusone