librdkafka icon indicating copy to clipboard operation
librdkafka copied to clipboard

Add timeout_ms option for rd_kafka_commit, rd_kafka_commit_message

Open kenneth-jia opened this issue 3 years ago • 2 comments

Add an additional parameter (timeout_ms) for rd_kafka_commit/rd_kafka_commit_message. To avoid stuck there forever while a consumer is trying to sync-commit but no response from brokers (e.g. brokers unexpected down)

kenneth-jia avatar Aug 03 '22 05:08 kenneth-jia

Hi, @edenhill , I found it's really hard to fix the check/style (pull_request) failure. I've tried clang-format -style=.clang-format, -- it didn't work; also tried make style-fix, but didn't work either. I guess the check/style is newly added but most source files would fail the checking at present (even with no change from this PR)? Thanks, Kenneth

kenneth-jia avatar Aug 03 '22 07:08 kenneth-jia

Regarding the style: clang-format seems to be broken on OSX. Running it on Linux yields good results.

edenhill avatar Oct 03 '22 12:10 edenhill

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Aug 21 '23 15:08 cla-assistant[bot]