librdkafka icon indicating copy to clipboard operation
librdkafka copied to clipboard

Published 20 hours ago • verified publisher icon confluentinc

Const correctness / documentation questions

Open omartijn opened this issue 5 years ago • 0 comments

Read the FAQ first: https://github.com/edenhill/librdkafka/wiki/FAQ

Description

I have just started looking at this library, and looking at the https://docs.confluent.io/current/clients/librdkafka/classRdKafka_1_1Producer.html#a540569ee0152703cdad4b45419f64b39 function, I see that the RdKafka::Producer::create function takes the conf parameter as non-const.

The documentation does not mention in what way it modifies the Conf object, and I couldn't think of a sensible change to be made to the conf during creation of the Producer. Is it possible that this is an oversight, and it should actually simply be const?

omartijn avatar Jun 07 '20 10:06 omartijn