ksql icon indicating copy to clipboard operation
ksql copied to clipboard

fix: turn on shared runtime flag

Open wcarlson5 opened this issue 2 years ago • 4 comments

Description

I am turning on the feature flag for shared runtimes by fault, I also found a couple tests that need to updated/ looked at.

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • [ ] Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • [ ] Ensure relevant issues are linked (description should include text like "Fixes #")

wcarlson5 avatar Mar 03 '22 17:03 wcarlson5

@ableegoldman we should look into these tests I marked. It seems that a few need to updated

cc @guozhangwang

wcarlson5 avatar Mar 03 '22 17:03 wcarlson5

@guozhangwang yes, these are the tests that will fail

wcarlson5 avatar Mar 03 '22 19:03 wcarlson5

All the tests are passing now. We should merge this as soon as 0.25 gets its own branches created

wcarlson5 avatar Mar 09 '22 19:03 wcarlson5

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 12 '22 21:04 CLAassistant