ksql icon indicating copy to clipboard operation
ksql copied to clipboard

fix: parser Removed KEY from nonReserved in SqlBase.g4

Open sukalpomitra opened this issue 4 years ago • 9 comments

Description

This fixes https://github.com/confluentinc/ksql/issues/6896. Removed KEY from nonReserved in SqlBase.g4 under ksqldb-parser pr

sukalpomitra avatar Mar 13 '21 09:03 sukalpomitra

It looks like @sukalpomitra hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence. Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

ghost avatar Mar 13 '21 09:03 ghost

[clabot:check]

sukalpomitra avatar Mar 13 '21 10:03 sukalpomitra

@confluentinc It looks like @sukalpomitra just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

ghost avatar Mar 13 '21 10:03 ghost

Screenshot 2021-03-16 at 12 05 57 AM hi @mjsax @agavra please help me. The error in jenkins build is nnot reproducible on my branch. How can I fix this test failure?

sukalpomitra avatar Mar 15 '21 16:03 sukalpomitra

hello @sukalpomitra thanks for the PR! You need to build locally for it to verify, do a mvn clean install -pl :ksqldb-parser and you should be able to reproduce the issue.

Perhaps more importantly, however, this isn't a backwards compatible change (which is why the tests are failing). We'll need to be thoughtful about how we make this change so as not to break existing applications.

agavra avatar Mar 17 '21 14:03 agavra

hi @agavra - All tests are passing Screenshot 2021-03-20 at 12 54 34 PM

sukalpomitra avatar Mar 20 '21 04:03 sukalpomitra

hello @sukalpomitra - tests are not passing in all modules (you can see the Jenkins CI build). I suspect the root cause is because of what I mentioned, that this change is not necessarily backwards compatible.

agavra avatar Mar 22 '21 17:03 agavra

@agavra i am unable to run tests. Have a look at this issue - https://forum.confluent.io/t/ksqldb-compilation-is-failing/1267

sukalpomitra avatar Mar 30 '21 13:03 sukalpomitra

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Nov 15 '23 20:11 cla-assistant[bot]

Closing stale PR. I'm sorry that we didn't get this done. Please resubmit as a new PR if you still want to get it in.

vvcephei avatar Feb 26 '24 16:02 vvcephei