ksql icon indicating copy to clipboard operation
ksql copied to clipboard

feat: Convert a Map of Structs to Array with Entries()

Open uurl opened this issue 4 years ago • 4 comments

Description

This PR fixes #5452 Convert a Map of Structs to Array with Entries()

Testing done

java io.confluent.ksql.function.udf.array.EntriesTest

Reviewer checklist

  • [ ] Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • [ ] Ensure relevant issues are linked (description should include text like "Fixes #")

uurl avatar Sep 19 '20 13:09 uurl

@confluentinc It looks like @uurl just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

ghost avatar Sep 19 '20 13:09 ghost

Thanks @uurl

It looks good, but I missed a test we need to add. It's in ksqldb-functional-tests/src/test/resources/query-validation-tests/array.json It has a test for queries sorted that uses ENTRIES in all supported types. Could you add one for the map of structs?

spena avatar Sep 28 '20 15:09 spena

@uurl Jenkins is failing, could you rebase your branch from master?

spena avatar Oct 15 '20 14:10 spena

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Nov 15 '23 20:11 cla-assistant[bot]