ksql icon indicating copy to clipboard operation
ksql copied to clipboard

fix(ksqldb-client-api): fix describeConnector issued query

Open bas-velthuizen opened this issue 2 years ago • 4 comments

This PR fixes issue #10150 Also, the unit test is made more strict to test for correct query

Description

The ClientImpl.describeConnector method does not add quotes around the connector name. This fix adds the quotes.

Testing done

The unit test has been expanded to verify the issued query.

Reviewer checklist

  • [ ] Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • [ ] Ensure relevant issues are linked (description should include text like "Fixes #")
  • [ ] Do these changes have compatibility implications for rollback? If so, ensure that the ksql command version is bumped.

bas-velthuizen avatar Dec 05 '23 13:12 bas-velthuizen

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Dec 05 '23 13:12 cla-assistant[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Bas Velthuizen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Dec 05 '23 13:12 cla-assistant[bot]

Jenkins seems to be failing, but I cannot get the current master of the repo to build on my own system, so I cannot check that. With version 7.5.2 as a base, the build did succeed locally.

bas-velthuizen-alfen avatar Dec 05 '23 13:12 bas-velthuizen-alfen