kafka-connect-storage-common icon indicating copy to clipboard operation
kafka-connect-storage-common copied to clipboard

Make the topic name configurable in storage paths

Open hariprasad-k opened this issue 4 years ago • 10 comments

Improvements to provide ability to exclude topic name in partition by configuration

hariprasad-k avatar Mar 05 '20 10:03 hariprasad-k

@confluentinc It looks like @hariprasad-k just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

ghost avatar Mar 05 '20 10:03 ghost

Fixed #126

hariprasad-k avatar Mar 05 '20 10:03 hariprasad-k

Question: What happens when you have topics as a list or topics.regex capture more than one topic?

Then all files in the directory will be of multiple topics?

OneCricketeer avatar Mar 11 '20 06:03 OneCricketeer

The patch also fixes #121 too

So does #122

OneCricketeer avatar Mar 11 '20 06:03 OneCricketeer

Question: What happens when you have topics as a list or topics.regex capture more than one topic?

Then all files in the directory will be of multiple topics?

@OneCricketeer Yes, all files of multiple topics will be in the same directory in this case.

But, this behavior will only happen if you use topics as a list or topics.regex in combination with path.include.topicname set as false. Further, as path.include.topicname is by default true, it will preserve the existing behavior by default.

hariprasad-k avatar Sep 09 '20 14:09 hariprasad-k

@OneCricketeer This PR does not have any changes related to Timestamp scaling factor anymore, which is covered by #160

Can you please review this changes ?

hariprasad-k avatar Sep 09 '20 16:09 hariprasad-k

I'm not a Confluent employee, so my reviews don't do anything

OneCricketeer avatar Sep 09 '20 16:09 OneCricketeer

Thanks @hariprasad-k for the contribution! This change will add flexibility to our connectors that use storage common to optionally exclude the topic name from the path (seems to be a popular request https://github.com/confluentinc/kafka-connect-hdfs/issues/544). I'd like to get second view from @levzem before proceeding.

dosvath avatar Mar 02 '21 23:03 dosvath

@dosvath @levzem Any thoughts, or plans to review this contribution ?

hariprasad-k avatar Mar 31 '21 12:03 hariprasad-k

Would be very much interested in having this feature integrated. The topic name being forcefully appended to the path limits us severely when sinking to already-established directory structures.

awebneck avatar Apr 19 '21 17:04 awebneck