kafka-connect-storage-cloud icon indicating copy to clipboard operation
kafka-connect-storage-cloud copied to clipboard

Allow integrity checks during upload

Open gnarula opened this issue 5 years ago • 8 comments

Adds a configuration that enables integrity checks using Content-MD5 headers for each chunk of a multi-part upload.

This would be useful to users who want to ensure no data corruption occurs during the upload.

Unfortunately, S3Mock doesn't check the header and therefore I couldn't write a test for it but the feature is documented here and the encoding is documented here and here

I'll be glad to add a test if there's an alternative to it

gnarula avatar Jun 08 '20 14:06 gnarula

@confluentinc It looks like @gnarula just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

ghost avatar Jun 08 '20 14:06 ghost

@kkonstantine Can you have a look at this please and suggest some feedback?

P.S. I wasn't sure whom to request for a review and I just went by the contribution count...

gnarula avatar Jun 16 '20 11:06 gnarula

Thanks for the PR @gnarula . Adding more people for review. I'll try to find some time to take a look too. The lack of support in unit tests is unfortunate.

kkonstantine avatar Jun 17 '20 06:06 kkonstantine

any news ?

raphaelauv avatar Apr 14 '21 22:04 raphaelauv

This PR has conflicts that would need to be resolved before review.

cjolivier01 avatar Dec 21 '21 18:12 cjolivier01

@C0urante @cjolivier01 also there are no unit/integration tests so we should add them. We should put this ticket in pipeline

kpatelatwork avatar Dec 21 '21 18:12 kpatelatwork

This PR is needed if we want to enable S3 Object Lock, otherwise it failed with:

Caused by: com.amazonaws.services.s3.model.AmazonS3Exception: Content-MD5 OR x-amz-checksum- HTTP header is required for Put Part requests with Object Lock parameters (Service: Amazon S3; Status Code: 400; Error Code: InvalidRequest; Request ID: SZFBSMA800XKHS0Y; S3 Extended Request ID: TjXtXuZl0UMCbHbwBb4FSrdTqHWgE37isKsngfW4rbgda3dvJXj9aOFvuiTobLEe9UOS+G/SFzk=; Proxy: null), S3 Extended Request ID: TjXtXuZl0UMCbHbwBb4FSrdTqHWgE37isKsngfW4rbgda3dvJXj9aOFvuiTobLEe9UOS+G/SFzk=

wpoch avatar Dec 21 '22 19:12 wpoch

Any updates here? Like the above comment, this change is needed when the s3 object-lock feature is enabled on the bucket.

wwakas avatar Jan 16 '24 09:01 wwakas