kafka-connect-jdbc icon indicating copy to clipboard operation
kafka-connect-jdbc copied to clipboard

CC-45: Added support for multiple timestamp columns

Open mikkin opened this issue 7 years ago • 4 comments

With this PR, users can specify multiple timestamp columns to address the scenario where they may have "modified" and "created" timestamp columns. They will need to list the column names in the order of priority. For e.g. modified, created - will look at modified column first and only if that column is null, it will proceed to created

There are checks in place to ensure that at least one of the timestamp column is not null.

Finally, added tests to validate the changes made.

mikkin avatar Nov 21 '17 23:11 mikkin

@wicknicks, @kkonstantine, @rhauch please review

mikkin avatar Dec 18 '17 20:12 mikkin

Thanks for the PR, Mikkin. LGTM.

wicknicks avatar Dec 18 '17 23:12 wicknicks

Is there a plan to release this feature?

mikeakala avatar Sep 30 '20 13:09 mikeakala

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Mikkin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Aug 01 '23 23:08 cla-assistant[bot]