kafka-connect-jdbc icon indicating copy to clipboard operation
kafka-connect-jdbc copied to clipboard

Add query.parameters configuration parameter

Open ITman1 opened this issue 2 years ago • 5 comments

Problem

We were unable to customize automatically generated SELECT in timestamp+incrementing mode as we needed. We tried custom query, suffix and delay configuration parameters, but none satisfied our needs. We would wanted something like the reverted incrementing+timestamp mode with possibility to look behind on the timestamp column. It is very specific problem what we have, I might try to explain it in the comments if you want.

Solution

We did not want to add yet another mode or another delay / timeout configuration therefore we added the possibility to define the SELECT query parameters based on user needs. Together with already existing query configuration parameter this allows anyone to define and parametrize final SELECT fully on his own.

Does this solution apply anywhere else?
  • [ ] yes
  • [x] no

Test Strategy

Testing done:
  • [x] Unit tests
  • [x] Integration tests
  • [ ] System tests
  • [ ] Manual tests

Release Plan

ITman1 avatar Feb 02 '23 19:02 ITman1

Hello @ManasjyotiSharma, @anupamaggarwal, @mukkachaitanya,

may I kindly ask you for a checking and approving this PR?

Thank you.

ITman1 avatar Feb 27 '23 20:02 ITman1

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Aug 01 '23 23:08 cla-assistant[bot]