kafka-connect-jdbc icon indicating copy to clipboard operation
kafka-connect-jdbc copied to clipboard

Use racially neutral terms in codebase

Open mimaison opened this issue 2 years ago • 1 comments

Problem

Some configurations and many variables throughout the code base use racially charged terms.

Solution

  • Introduce new configurations. Existing configurations using racially charged terms are marked as deprecated.
  • Update variables to use racially neutral terms only.
Does this solution apply anywhere else?

N/A

Test Strategy

Updated existing tests + added some new for logic handling new configurations.

Testing done:
  • [x] Unit tests
  • [ ] Integration tests: I tried running them but they all fail:
[ERROR] io.confluent.connect.jdbc.source.integration.MySQLOOMIT.testStreamingReads  Time elapsed: 0.902 s  <<< ERROR!
ch.vorburger.exec.ManagedProcessException: An error occurred while installing the database
[ERROR] io.confluent.connect.jdbc.source.integration.PostgresOOMIT.testTableLocksWithStreamingReads  Time elapsed: 0.154 s  <<< ERROR!
java.lang.IllegalStateException: Process [/var/folders/6f/c4r3kvwd76l9c0k_59qzh_r00000gn/T/embedded-pg/PG-2c0c4f55a015ab253337e3d05ca5fd21/bin/initdb, -A, trust, -U, postgres, -D, /var/folders/6f/c4r3kvwd76l9c0k_59qzh_r00000gn/T/epg3642288202649490811, -E, UTF-8] failed
[ERROR] io.confluent.connect.jdbc.source.integration.PostgresOOMIT.testStreamingReads  Time elapsed: 0.011 s  <<< ERROR!
java.lang.IllegalStateException: Process [/var/folders/6f/c4r3kvwd76l9c0k_59qzh_r00000gn/T/embedded-pg/PG-2c0c4f55a015ab253337e3d05ca5fd21/bin/initdb, -A, trust, -U, postgres, -D, /var/folders/6f/c4r3kvwd76l9c0k_59qzh_r00000gn/T/epg8522825206449835467, -E, UTF-8] failed
  • [ ] System tests
  • [ ] Manual tests

Release Plan

mimaison avatar Aug 07 '22 16:08 mimaison

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 07 '22 16:08 CLAassistant

I'm not going to sign the CLA, so closing this PR

mimaison avatar Jun 16 '23 09:06 mimaison