kafka-connect-jdbc
kafka-connect-jdbc copied to clipboard
Allow close() on CachedConnectionProvider while attempting to connect…
… (#1205)
Problem
While CacheConenctionProvider is trying to get a connection, it is impossible to stop.
Solution
Add a flag to not go on with connection attempt when a close request has been issued.
Does this solution apply anywhere else?
- [ ] yes
- [ x] no
If yes, where?
Test Strategy
Testing done:
- [ x] Unit tests
- [ ] Integration tests
- [ ] System tests
- [ ] Manual tests
Release Plan
Hi @fred-ro! Thanks for the PR, and really sorry for the delay. I'll take a look at this. I see this is a bug fix that could be ported back as old as 5.0.x (I am not sure if we still support the 5.0.x, but sure we do support 5.5.x still). It could be great if you could rebase this PR to 5.0.x branch, then once merged, we can forward merge the changes. Do let me know if you have any concerns!
It's now rebased onto branch 5.0.x