kafka-connect-jdbc icon indicating copy to clipboard operation
kafka-connect-jdbc copied to clipboard

Allow close() on CachedConnectionProvider while attempting to connect…

Open fred-ro opened this issue 2 years ago • 1 comments

… (#1205)

Problem

While CacheConenctionProvider is trying to get a connection, it is impossible to stop.

Solution

Add a flag to not go on with connection attempt when a close request has been issued.

Does this solution apply anywhere else?
  • [ ] yes
  • [ x] no
If yes, where?

Test Strategy

Testing done:
  • [ x] Unit tests
  • [ ] Integration tests
  • [ ] System tests
  • [ ] Manual tests

Release Plan

fred-ro avatar Jun 17 '22 14:06 fred-ro

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 17 '22 14:06 CLAassistant

Hi @fred-ro! Thanks for the PR, and really sorry for the delay. I'll take a look at this. I see this is a bug fix that could be ported back as old as 5.0.x (I am not sure if we still support the 5.0.x, but sure we do support 5.5.x still). It could be great if you could rebase this PR to 5.0.x branch, then once merged, we can forward merge the changes. Do let me know if you have any concerns!

mukkachaitanya avatar Nov 09 '22 07:11 mukkachaitanya

It's now rebased onto branch 5.0.x

fred-ro avatar Nov 28 '22 12:11 fred-ro