kafka-connect-elasticsearch icon indicating copy to clipboard operation
kafka-connect-elasticsearch copied to clipboard

Implement the AWS Elasticsearch signer

Open asiragusa opened this issue 5 years ago • 9 comments

This PR implements the AWS Elasticsearch signer. It can be enabled with the parameter aws.signing.enabled.

I borrowed some code from https://github.com/confluentinc/kafka-connect-storage-cloud/blob/master/kafka-connect-s3/src/main/java/io/confluent/connect/s3/S3SinkConnectorConfig.java

asiragusa avatar Aug 05 '19 13:08 asiragusa

It looks like @asiragusa hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence. Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

ghost avatar Aug 05 '19 13:08 ghost

[clabot:check]

asiragusa avatar Aug 05 '19 13:08 asiragusa

@confluentinc It looks like @asiragusa just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

ghost avatar Aug 05 '19 13:08 ghost

@asiragusa , thanks for submitting this PR. A project I am working on also needs this functionality. Just checking to see if you will be resolving the merge conflicts so that this PR can be accepted / merged? Thanks!

peterb154 avatar Aug 31 '20 16:08 peterb154

@peterb154 I don't think that I will have the time to do this in the near future. In any case the PR is quite small and resolving the conflicts should be easy

asiragusa avatar Sep 01 '20 09:09 asiragusa

Are there plan to finalize and merge this PR?

Fodoj avatar Feb 26 '21 08:02 Fodoj

Are there plan to merge this PR?

MohamedRDwedar avatar May 11 '21 01:05 MohamedRDwedar

Not by me.

On Mon, May 10, 2021, 8:45 PM MohamedRDwedar @.***> wrote:

Are there plan to merge this PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/confluentinc/kafka-connect-elasticsearch/pull/330#issuecomment-837621946, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHRWIHIU75G7AT77SBYQB3TNCD4LANCNFSM4IJLK7TQ .

peterb154 avatar May 11 '21 03:05 peterb154

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Sep 11 '23 09:09 cla-assistant[bot]