ducktape icon indicating copy to clipboard operation
ducktape copied to clipboard

Support '--info' to pipe info logs to stdout

Open chia7712 opened this issue 4 years ago • 4 comments

fix #260

chia7712 avatar Jan 05 '21 07:01 chia7712

It looks like @chia7712 hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence. Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

ghost avatar Jan 05 '21 07:01 ghost

@ewencp Thanks for your quick response!

For this timeout issue, it seems to me the control of outputting something to make CI happy should be up to ducktape users, because they are able to set the suitable/meaningful output. It is nice that TestRunner emits something periodically for Kafka but it could be noisy to other users who don't require those periodical outputs.

Personally, adding a "configurable" option to enable/disable much/less messages is more flexible and it can be transparent to "non-kafka" users. WDYT?

I actually like the direction of the patch generally to shift away from debug parameters to more general log_level parameters, though test.py changes in particular would need compatibility tests since I'm pretty sure the change of parameter names would be breaking

oh, I didn't notice related function calls. Will check them later.

chia7712 avatar Jan 05 '21 08:01 chia7712

I think both --info and periodic printing of status updates are useful in their own ways. When running tests locally via ducker-ak, for example, it would be useful to see all info output. Periodic printing can also be made configurable (turn it on/off via a separate cmd line flag).

So if I understand the discussion above correctly, there are two open quesions:

  • changing parameter names can break stuff - need to check if it is so or not
  • whether to use --debug/--info flags, having a way to feed in a more general logging config which I think is a good idea for ducktape 1.0 release, but not necessarily required short term. Unless we simply introduce an additional --log-level flag instead of --info.

stan-is-hate avatar Feb 23 '21 00:02 stan-is-hate

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Aug 16 '23 04:08 cla-assistant[bot]