demo-scene icon indicating copy to clipboard operation
demo-scene copied to clipboard

Replace old java-faker with kotlin-faker

Open serpro69 opened this issue 2 years ago • 4 comments

Replaced an old and buggy java-faker with kotlin-faker :) Probably not much of a difference for a demo, but it's my first contribution here, so hopefully it's ok :)

Tests in event-driven-microservices-workshop module still fail, but they were failing even before this change, so I assume it's intentional, since this is a workshop code.

serpro69 avatar Jul 08 '22 06:07 serpro69

@serpro69 for my own education, can you please elaborate on why Kotlin Faker is a better replacement (beyond "old and buggy java-faker")?

@MichaelDrogalis from your work on https://github.com/MichaelDrogalis/voluble which uses Java Faker , do you have an opinion on this PR?

ybyzek avatar Jul 08 '22 13:07 ybyzek

Hi @ybyzek , kotlin faker offers more data providers, locales, and has extra "batteries" included as well - random instances of classes, unique values, etc. In addition to the above it's also faster. You can also check some comparisons here if you're interested ;)

serpro69 avatar Jul 08 '22 14:07 serpro69

ping @MichaelDrogalis @ybyzek for input here plz

rmoff avatar Aug 05 '22 10:08 rmoff

@MichaelDrogalis any thoughts on this? thanks!

rmoff avatar Sep 12 '22 09:09 rmoff