cp-helm-charts icon indicating copy to clipboard operation
cp-helm-charts copied to clipboard

fix(cp-schema-registry): Support creating secrets and volumes

Open joshuasimon-taulia opened this issue 3 years ago • 5 comments

This is basically copy/pasting #389 and applying it to schema-registry

What changes were proposed in this pull request?

  • This PR allows creating Kubernetes secret and mounting volumes
  • Explanatory comments have been added in the values file for the newly introduced values

How was this patch tested?

  • helm template locally
  • kubectl apply against a v1.19.9-gke.1400 cluster
  • the testing done against previous PR

joshuasimon-taulia avatar Jun 02 '21 21:06 joshuasimon-taulia

It looks like @joshuasimon-taulia hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence. Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

ghost avatar Jun 02 '21 21:06 ghost

[clabot:check]

joshuasimon-taulia avatar Jun 02 '21 21:06 joshuasimon-taulia

@confluentinc It looks like @joshuasimon-taulia just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

ghost avatar Jun 02 '21 21:06 ghost

i've been running these changes since June 2 without any issues. @SoerenHenning @OuesFa @kppullin anyone with merge access around?

joshuasimon-taulia avatar Aug 05 '21 18:08 joshuasimon-taulia

@gAmUssA mind taking a look?

joshuasimon-taulia avatar Jan 19 '22 17:01 joshuasimon-taulia