cp-helm-charts icon indicating copy to clipboard operation
cp-helm-charts copied to clipboard

podLabels added to cp-kafka-rest deployment.yaml

Open LeonardoBonacci opened this issue 3 years ago • 5 comments

What changes were proposed in this pull request?

A common use-case, one we bumped into immediately when deciding to try out the rest proxy helm charts, is to allow for labels to be (dynamically) added to pods. To facilitate this only a small code-addition is needed.

This PR contains the necessary change(s) to templates/deployment.yaml.

How was this patch tested?

  • label harry: "potter" added to values.yaml
## Custom pod labels
podLabels:
  harry: "potter"
  • helm install on Kube-Docker-Desktop
  • k get -o yaml pod/rp-cp-kafka-rest-1234567890 Voila:
labels:
    app: cp-kafka-rest
    harry: potter
    pod-template-hash: 6bb58dd6bd
    release: rp
  • label lord: "voldemort" added to values.yaml
## Custom pod labels
podLabels:
  harry: "potter"
  lord: "voldemort"
  • helm install on Kube-Docker-Desktop
  • k get -o yaml pod/rp-cp-kafka-rest-0987654321 Voila once more:
 labels:
    app: cp-kafka-rest
    harry: potter
    lord: voldemort
    pod-template-hash: 669dd7cc89
    release: rp

LeonardoBonacci avatar May 27 '21 21:05 LeonardoBonacci

It looks like @LeonardoBonacci hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence. Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

ghost avatar May 27 '21 21:05 ghost

[clabot:check]

LeonardoBonacci avatar May 27 '21 21:05 LeonardoBonacci

@confluentinc It looks like @LeonardoBonacci just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

ghost avatar May 27 '21 21:05 ghost

Anyone?

LeonardoBonacci avatar Jun 05 '21 18:06 LeonardoBonacci