cp-helm-charts
cp-helm-charts copied to clipboard
confluentinc
Add kafka-connect url to ksqldb
What changes were proposed in this pull request?
Add the env variable "KSQL_KSQL_CONNECT_URL" to the KSQLDB deployment to be able to create connector viq ksql queries.
How was this patch tested?
I pushed this PR into minikube and Amazon EKS successfully.
It looks like @Hamdiovish hasn't signed our Contributor License Agreement, yet.
The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence. Wikipedia
You can read and sign our full Contributor License Agreement here.
Once you've signed reply with [clabot:check] to prove it.
Appreciation of efforts,
clabot
@confluentinc It looks like @Hamdiovish just signed our Contributor License Agreement. :+1:
Always at your service,
clabot
Can sbdy merge this plz? It's quite blocking not to be able to set this kafka connect URL...
@cbonami i think that it can be done using the “ customEnv” like following way: `cp-control-center: enabled: true configurationOverrides: "replication.factor": "1"
customEnv: "CONTROL_CENTER_CONNECT_CP-KAFKA-CONNECT_CLUSTER" : "http://kafka-cp-kafka-connect:8083" `
I’ve just used this workaround to push a new environment variable to control center settings.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Hamdi Ben Salah seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
@Hamdiovish kindly send PR against this repo So I can review and merge it https://github.com/confluent-helm-charts/cp-helm-charts