Add support for Prometheus Operator's ServiceMonitor resource

[tczekajlo]

What changes were proposed in this pull request?

• add support for ServiceMonitor resource which is provided by prometheus-operator

How was this patch tested?

helm upgrade/install on a testing cluster, k8s v1.11.8, prometheus-operator-4.3.3 chart

[ghost]

It looks like @tczekajlo hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence. Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

[tczekajlo]

[clabot:check]

[ghost]

@confluentinc It looks like @tczekajlo just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

[qshao-pivotal]

Could you update the docs also

[tczekajlo]

@qshao-pivotal I've updated docs. I hope this is the correct place.

[terryf82]

This looks super helpful and ready to go, with documentation updates in place. Any reason why it hasn't been merged?

[azhang]

  Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(Service.spec.ports[0].port): invalid type for io.k8s.api.core.v1.ServicePort.port: got "string", expected "integer"
  Error: plugin "diff" exited with error

I get this when running through helmfile

the fix is easy. remove the part in bold

spec: ports: - port: {{ .Values.prometheus.jmx.port | quote }} name: metrics

~~another thing to note: servicemonitor definitions must be in the same namespace as prometheus. by default this puts the servicemonitor in the helm namespace, which may or may not be the same as prometheus~~ note: Must override this value in order to use servicemonitors outside of the prometheus namespace:

    - prometheus:
        prometheusSpec:
          serviceMonitorSelectorNilUsesHelmValues: false

---

oct 13 2020 update: charts/cp-*/templates/service-metrics.yaml can be deleted since master already defines this service in .../service.yaml.

[Jefski14]

Any reason for this to still not be merged? Seems like the checks failed because of server maintenance, could we retry the checks?