cp-docker-images
cp-docker-images copied to clipboard
Ensure script is wrong for rest proxy in SASL_PLAINTEXT or SASL_SSL mode
Overall, I would be overly cautious about that kafka-ready script, and would love to have an environment variable to disable it. It causes a lot of issue on our end and we have to override it by mounting a volume with an empty file.
This line: https://github.com/confluentinc/cp-docker-images/blob/v3.2.1/debian/kafka-rest/include/etc/confluent/docker/ensure#L27
doesn't have cases for SASL_SSL, SASL_PLAINTEXT, therefore reverts to the basic:
cub kafka-ready \
"${KAFKA_REST_CUB_KAFKA_MIN_BROKERS:-1}" \
"${KAFKA_REST_CUB_KAFKA_TIMEOUT:-40}" \
-z "$KAFKA_REST_ZOOKEEPER_CONNECT"
Which may fail heavily.
I believe most of the ensure scripts are not in sync anyway across the docker images. At the very least, they should ignore SASL_SSL and SASL_PLAINTEXT if anything, or you could provide an environment variable to skip the checks.
Let me know your thoughts,
Regards, Stephane
I suspect that this is a duplicate of #385 and is resolved by #392