cp-demo icon indicating copy to clipboard operation
cp-demo copied to clipboard

Include JMX Monitoring stacks on Gitpod configuration

Open jeqo opened this issue 3 years ago • 4 comments

Description

What behavior does this PR change, and why?

While enabling gitpod on jmx-monitoring-stacks repo (https://github.com/confluentinc/jmx-monitoring-stacks/pull/54), it made sense to extend cp-demo instead of copy/paste'ing most of the gitpod configuration in another project.

This PR adds a new variable MONITORING_STACK to choose which stack to start, if any, when starting cp-demo on gitpod.

Author Validation

Describe the validation already done, or needs to be done, by the PR submitter.

Reviewer Tasks

Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.

jeqo avatar Nov 02 '21 17:11 jeqo

gitpod-io[bot] avatar Nov 02 '21 17:11 gitpod-io[bot]

Am I the only one getting for https://gitpod.io/#https://github.com/confluentinc/cp-demo/pull/401 ?

CleanShot 2021-11-03 at 11 22 37@2x

vdesabou avatar Nov 03 '21 10:11 vdesabou

@vdesabou it works for me: https://gray-bee-8m5ifxwq.ws-us17.gitpod.io/ Screenshot 2021-11-03 at 05 24 45

jeqo avatar Nov 03 '21 10:11 jeqo

I'm working on some other gitpod prebuild optimizations in https://github.com/confluentinc/cp-demo/pull/419 that would need to go through before adding this. Hold tight, and thank you for contributing this!

chuck-confluent avatar Apr 11 '22 20:04 chuck-confluent

Sorry for the delay on this. I've since discovered that CP demo is pushing the resource limitations of gitpod quite a bit, so i don't think it's feasible to run more components. I'll have to close this PR, unfortunately.

chuck-confluent avatar Aug 30 '22 19:08 chuck-confluent