cp-ansible
cp-ansible copied to clipboard
kafka_connectors module: fix for issue 401
Description
revamped error management, status check on the connector tasks
Fixes #401
Type of change
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
How Has This Been Tested?
Tested and debugged locally with multiple connectors (using file sink) over python 2 and 3.
Test Configuration:
Checklist:
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] Any dependent changes have been merged and published in downstream modules
- [ ] Any variable changes have been validated to be backwards compatible
Hello @ldom Sorry for long pending action item on this PR.
Does this PR still hold good ? If thats the case, can you please target this to 6.0.x branch and merge the changes in https://github.com/confluentinc/cp-ansible/compare/6.0.0-post...jeqo:fix-401 . Thanks!
Hello @ldom Sorry for long pending action item on this PR.
Does this PR still hold good ? If thats the case, can you please target this to 6.0.x branch and merge the changes in https://github.com/confluentinc/cp-ansible/compare/6.0.0-post...jeqo:fix-401 . Thanks!
A friendly reminder @ldom
Sorry @nsharma-git, just got back. This PR still holds good and I'll change the target branch, but the main issue is that I never got the molecule test environment up properly and I lack time to work on it. However, the fix is definitely useful and actually used at some customer sites.
Sorry @nsharma-git, just got back. This PR still holds good and I'll change the target branch, but the main issue is that I never got the molecule test environment up properly and I lack time to work on it. However, the fix is definitely useful and actually used at some customer sites.
Thanks @ldom. Will see, if we can help here.
Thank you @ldom for your help and contribution! :) we have now added molecule scenarios on top of this PR + fixed some known issues in kafka_connectors module to support ssl_enabled=true. Here's the PR https://github.com/confluentinc/cp-ansible/pull/1296 Closing this one. thx