confluent-kafka-python
confluent-kafka-python copied to clipboard
confluentinc
Fix segfault with describe_topics and flaky connection
If you call describe_topics on a flaky connection, sometimes the admin client reply has the host set to a null pointer. When this occurs, instead of segfaulting, report the host as None.
![cla-assistant[bot] avatar](https://avatars.githubusercontent.com/in/128106?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Thanks for the PR.
Even though the changes seems correct, I think we should not change the base implementation which is being used in alot of APIs. Some of the values of other APIs must not be NULL. I think its better to handle the scenario in this way - https://github.com/confluentinc/confluent-kafka-python/blob/master/src/confluent_kafka/src/Admin.c#L3198-L3201.
I am also checking if it should be possible to get the host information as NULL or should we handle it as an error instead. But in the meantime you can rebase the branch and do the change mentioned above if you have time. Otherwise, you can wait for my revert.
But in the meantime you can rebase the branch and do the change mentioned above if you have time.
Done.
@lpsinger after reviewing all the cases only in c_Node_to_py it's needed to check for NULL values because it takes the nodes from the Metadata request and some of then can be absent, so without host, when the broker is down and not listed there.
Could you leave only that change?
Could you leave only that change?
Done. Would you like me to squash the changes?