confluent-kafka-python icon indicating copy to clipboard operation
confluent-kafka-python copied to clipboard

Don't call `PyEval_InitThreads()` when using Python >= 3.7

Open chrisnovakovic opened this issue 4 years ago • 8 comments

PyEval_InitThreads() is redundant as of Python 3.7, is a no-op (and is deprecated) as of Python 3.9, and will be removed in Python 3.11 - only call it when using Python 3.6 or below.

chrisnovakovic avatar Sep 02 '21 12:09 chrisnovakovic

It looks like @chrisnovakovic hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence. Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

ghost avatar Sep 02 '21 12:09 ghost

[clabot:check]

chrisnovakovic avatar Sep 02 '21 12:09 chrisnovakovic

@confluentinc It looks like @chrisnovakovic just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

ghost avatar Sep 02 '21 12:09 ghost

Can you force-push to this PR again to trigger CI jobs?

edenhill avatar Sep 20 '21 08:09 edenhill

Sure thing. Sorry for the delay!

chrisnovakovic avatar Sep 20 '21 22:09 chrisnovakovic

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 27 '23 21:01 CLAassistant

Rebased on master.

chrisnovakovic avatar Jan 27 '23 21:01 chrisnovakovic

:tada: All Contributor License Agreements have been signed. Ready to merge.
:white_check_mark: chrisnovakovic
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.