confluent-kafka-python icon indicating copy to clipboard operation
confluent-kafka-python copied to clipboard

Changes to create and publish arm64 wheel

Open tbbharaj opened this issue 2 years ago • 17 comments

This PR addresses the issue to build arm64 wheels. Successful Build

If there are any questions/comments - I'd be happy fix things as needed. Issue: https://github.com/confluentinc/confluent-kafka-python/issues/1182

Thank you Tanveen

tbbharaj avatar Jul 09 '21 04:07 tbbharaj

It looks like @tbbharaj hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence. Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

ghost avatar Jul 09 '21 04:07 ghost

It looks like @tbbharaj hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence. Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

[clabot:check]

tbbharaj avatar Jul 23 '21 14:07 tbbharaj

@confluentinc It looks like @tbbharaj just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

ghost avatar Jul 23 '21 14:07 ghost

Following up on this PR addressing the issue to build arm64 wheels. Happy to address any feedbacks/comments.

Thank you!

tbbharaj avatar Jul 29 '21 14:07 tbbharaj

Any chance of getting this reviewed? I'd love to see a wheel for arm64.

AGSaidi avatar Oct 11 '21 20:10 AGSaidi

Looking to get reviews/feedbacks on this PR to get support for aarch64 wheels

Thank you!

tbbharaj avatar Dec 16 '21 16:12 tbbharaj

Sorry for the delay. We'll move to a different CI system beginning of next year, so this PR will need to sit idle until that is in place.

Thanks for your patience.

edenhill avatar Dec 16 '21 16:12 edenhill

Sorry for the delay. We'll move to a different CI system beginning of next year, so this PR will need to sit idle until that is in place.

Thanks for your patience.

Hello @edenhill, Wanted to check if there's an update...are we good with current PR or need new PR to support aarch64 wheels?

tbbharaj avatar Feb 14 '22 16:02 tbbharaj

@tbbharaj , thanks for the fix, can you please do a git rebase from master and then push again to this branch to trigger another CI test?

jliunyu avatar Apr 22 '22 18:04 jliunyu

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 22 '22 18:04 CLAassistant

@tbbharaj , thanks for the fix, can you please do a git rebase from master and then push again to this branch to trigger another CI test?

@jliunyu sure let me check this again

tbbharaj avatar Apr 22 '22 18:04 tbbharaj

@tbbharaj , thanks for the fix, can you please do a git rebase from master and then push again to this branch to trigger another CI test?

@jliunyu sure let me check this again

@tbbharaj , thanks for the fix, can you please do a git rebase from master and then push again to this branch to trigger another CI test?

@jliunyu sure let me check this again

I am getting build failure: https://app.travis-ci.com/github/confluentinc/confluent-kafka-python/jobs/567975406. zlib installation fails as https://zlib.net/zlib-1.2.11.tar.gz returns 404. The latest one is zlib == 1.2.12 https://zlib.net/zlib-1.2.12.tar.gz but for that librdkafka needs to be upgraded to 1.9.0 as per change logs: https://github.com/edenhill/librdkafka/blob/master/CHANGELOG.md

Tried upgrading librdkafka to 1.9.0 but https://github.com/edenhill/librdkafka/archive/v1.9.0.tar.gz returneed 404

tbbharaj avatar Apr 23 '22 00:04 tbbharaj

@tbbharaj , thanks for the fix, can you please do a git rebase from master and then push again to this branch to trigger another CI test?

@jliunyu sure let me check this again

@tbbharaj , thanks for the fix, can you please do a git rebase from master and then push again to this branch to trigger another CI test?

@jliunyu sure let me check this again

Looks like we are getting build failure: https://app.travis-ci.com/github/confluentinc/confluent-kafka-python/jobs/567975406 zlib installation fails as https://zlib.net/zlib-1.2.11.tar.gz returns 404. The latest one is zlib == 1.2.12 https://zlib.net/zlib-1.2.12.tar.gz but for that librdkafka needs to be upgraded to 1.9.0 as per change logs: https://github.com/edenhill/librdkafka/blob/master/CHANGELOG.md

Tried upgrading librdkafka to 1.9.0 but https://github.com/edenhill/librdkafka/archive/v1.9.0.tar.gz returns 404

tbbharaj avatar Apr 23 '22 00:04 tbbharaj

@tbbharaj The new librdkafka is now available at that link which was dead in April. I would love if this PR could be merged.

cablespaghetti avatar Jun 17 '22 12:06 cablespaghetti

we're in the process of moving away from travis ci, apologies it's taking some time.

mhowlett avatar Jun 17 '22 14:06 mhowlett

we're in the process of moving away from travis ci, apologies it's taking some time.

Is there a timeline?

With the new hard requirement on librdkafka 1.9.0, it's gotten a lot harder to the package working on arm64 (previously you could at least use OS packages).

jalaziz avatar Jun 24 '22 02:06 jalaziz

It would be really helpful if this gets merged

ivanklimberg avatar Jul 21 '22 15:07 ivanklimberg

@mhowlett is there anything I can do to help push this through?

hsheth2 avatar Dec 08 '22 18:12 hsheth2