confluent-kafka-go icon indicating copy to clipboard operation
confluent-kafka-go copied to clipboard

Published 20 hours ago • verified publisher icon confluentinc

Deprecate channel based consumer

Open eran-levy opened this issue 4 years ago • 4 comments

Fixes #545

There are still few tests such as the consumer_performance_test which are using the channel based consumer but I will create another issue to address that specifically.

eran-levy avatar Oct 24 '20 20:10 eran-levy

@confluentinc It looks like @eran-levy just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

ghost avatar Oct 24 '20 20:10 ghost

it looks like there are some issues with the tests that arent relevant to this PR specifically, created this issue to address that #548

eran-levy avatar Oct 24 '20 21:10 eran-levy

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Eran Levy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 01 '22 15:04 CLAassistant

@edenhill would you like to schedule this full deprecation for 1.9 as well?

eran-levy avatar Apr 19 '22 06:04 eran-levy

Thanks for this PR! Closing this with #894 , we were able to deprecate channel based consumers.

milindl avatar May 15 '23 16:05 milindl