confluent-kafka-dotnet icon indicating copy to clipboard operation
confluent-kafka-dotnet copied to clipboard

Published 20 hours ago • verified publisher icon confluentinc

Update NJsonSchema to v11

Open NoahStolk opened this issue 1 year ago • 1 comments

Fixes https://github.com/confluentinc/confluent-kafka-dotnet/issues/2169

A few notes:

  • This is a breaking change, and should be included in a major version release only, as we're dropping support for NJsonSchema v10. This change will impact users that manage their own references to NJsonSchema v10.
  • Newtonsoft.Json-based generators have been moved to a separate NuGet package, so the reference to NJsonSchema has been replaced with a reference to NJsonSchema.NewtonsoftJson. See NSwag 14 announcement and NJsonSchema v11 release notes.
  • EnumHandling no longer exists, so the WithJsonSchemaGeneratorSettingsSerDe unit test has been updated to use JsonSerializerSettings instead.

NoahStolk avatar Feb 05 '24 19:02 NoahStolk

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Feb 05 '24 19:02 cla-assistant[bot]

For some reason the PR is stuck on "Processing updates"... Will close and re-open to see if that helps.

NoahStolk avatar Jul 16 '24 08:07 NoahStolk

image

I can't re-open it. I think the PR broke because the fork source was changed to https://github.com/ah-/confluent-kafka-dotnet for some reason...

NoahStolk avatar Jul 16 '24 08:07 NoahStolk

I've opened a new PR: https://github.com/confluentinc/confluent-kafka-dotnet/pull/2263

NoahStolk avatar Jul 16 '24 08:07 NoahStolk