confluent-kafka-dotnet icon indicating copy to clipboard operation
confluent-kafka-dotnet copied to clipboard

Binary Producer with Span<T>

Open alec-anikin opened this issue 4 years ago • 10 comments

Hi Matt, I've prepared the draft for binary producer with span api. I tried to minimize the number of changes to make it easier to review.

alec-anikin avatar May 03 '21 18:05 alec-anikin

@confluentinc It looks like @alec-anikin just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

ghost avatar May 03 '21 18:05 ghost

thanks for the PR @alec-anikin - this will take a lot of effort to review and get merged (there's a good chance that in a PR this big we will have disagreements to work through). pretty sure I won't have time to get to it in the short term.

do you have any numbers on performance/memory improvements?

mhowlett avatar May 04 '21 13:05 mhowlett

There are no performance improvements on the library side but clients can now allocate key/values on stack (stackallock), native memory(Marshal.AllocHGlobal) and ArrayPool. So they can get a lot of improvements in terms of memory allocations.

alec-anikin avatar May 04 '21 17:05 alec-anikin

Amazing work!

msallin avatar Aug 11 '21 22:08 msallin

@mhowlett this should be a high priority... Any plans to work on it?

msallin avatar Nov 12 '21 16:11 msallin

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 18 '22 15:06 CLAassistant

it's on the radar, and i'd like to be working on it, but some other things have been prioritized ahead of it.

mhowlett avatar Jun 20 '22 02:06 mhowlett