cli icon indicating copy to clipboard operation
cli copied to clipboard

[CLI-2908] Add plugin uninstall command

Open tmalikconfluent opened this issue 1 year ago • 5 comments

Release Notes

New Features

  • Added confluent plugin uninstall command for Confluent Platform

Checklist

  • [ ] Leave this box unchecked if features are not yet available in production

What

Added plugin uninstall command to remove the plugins that are no longer needed for a user. Also added the ID for a particular plugin in the command plugin list (which can be used as the flag in uninstall) and changed the one of the column names in plugin search for the sake of consistency with list command

References

https://confluentinc.atlassian.net/browse/CLI-2908

Test & Review

Created a new function in the TestPluginUninstall in the plugin_test.go class to test the unistall functionality added. This involved creating a dummy plugin, uninstalling it and checking that the plugin list command gives the expected output after the uninstall. For manual testing, added one of the plugins using the install. Verified it using plugin list command. Then uninstalled it using the plugin uninstall command and again verified the results using the plugin list command.

tmalikconfluent avatar May 13 '24 23:05 tmalikconfluent

Added Plugin uninstall command

Make sure you:

  1. Start this release note with a dash "-" (bullet point)
  2. Format the full command name with backticks so it looks like confluent plugin install
  3. Specify that this command is only for Confluent Platform (I'm pretty sure this is not compatible with Confluent Cloud)

brianstrauch avatar May 13 '24 23:05 brianstrauch

@brianstrauch The plugin command is for both Cloud and Platform (the connect plugin install is Platform only though)

sgagniere avatar May 14 '24 02:05 sgagniere

@brianstrauch The plugin command is for both Cloud and Platform (the connect plugin install is Platform only though)

Since connect plugin install is platform-only, it makes sense that uninstall is also platform-only, right?

brianstrauch avatar May 14 '24 15:05 brianstrauch

the uninstall works very similar to delete functionality for various other commands, maybe that is why we need it for both cloud and platform? Also have made the other changes you suggested

tmalikconfluent avatar May 14 '24 15:05 tmalikconfluent

the uninstall works very similar to delete functionality for various other commands, maybe that is why we need it for both cloud and platform? Also have made the other changes you suggested

Hmm :thinking: since we're only able to install plugins locally with Confluent Platform, I don't think giving Cloud users the option to uninstall would serve any purpose.

brianstrauch avatar May 14 '24 16:05 brianstrauch

Since this PR is against the v4 branch, I assume there's at least one breaking change. Can you include that in the release notes section and then work with @sgagniere to get that added to the main v4 PR release notes?

brianstrauch avatar May 28 '24 18:05 brianstrauch