cli icon indicating copy to clipboard operation
cli copied to clipboard
verified publisher icon confluentinc

[CLI-2360] Revoking Auth0 refresh token on cloud logout

Open kevin-wu24 opened this issue 2 years ago • 2 comments

Release Notes

Bug Fixes

  • confluent logout revokes the refresh token when logging out of Confluent Cloud

Checklist

  1. [CRUCIAL] Is the change for features that are already live in prod?
    • yes: ok

What

Running confluent logout for cloud users now makes a request to DELETE /api/sessions.

References

https://confluentinc.atlassian.net/browse/CLI-2360 https://github.com/confluentinc/ccloud-sdk-go-v1-public/pull/24

Test & Review

Unit and integration tests still pass Request returns a reply with code 200 OK.

kevin-wu24 avatar Aug 22 '23 20:08 kevin-wu24

Have you manually tested, that IsSSO field in get ccloud credentials is always correct?

MuweiHe avatar Aug 23 '23 05:08 MuweiHe

Have you manually tested, that IsSSO field in get ccloud credentials is always correct?

yup! It's the same code that used to exist in login/command.go, but I just moved it to pkg since it is shared.

EDIT: did some refactoring and it turns out we don't even need to call the getCCloudCredentials function, since logout an authenticated command now.

kevin-wu24 avatar Aug 23 '23 12:08 kevin-wu24

I switched the target from main to v4 and worked out the merge conflicts, so I think this is ready for review again.

sgagniere avatar Jun 29 '24 02:06 sgagniere