bincover icon indicating copy to clipboard operation
bincover copied to clipboard

Published 20 hours ago • verified publisher icon confluentinc

Add the ability to suppress non-zero exits as errors

Open dnnrly opened this issue 2 years ago • 5 comments

This allows you to test the output exactly as returned by the binary, without having to parse the error to extract any meaning.

dnnrly avatar May 10 '22 22:05 dnnrly

LGTM!

MuweiHe avatar Jan 17 '23 20:01 MuweiHe

The latest changes from master will have to be merged in for CI to pass @dnnrly

brianstrauch avatar Jan 23 '23 20:01 brianstrauch

Apologies, I'd completely forgotten I'd raised this PR. I'm afraid I'm away from my laptop for a little while so won't be able to fix anything if it breaks when I merge those changes in.

Given the upcoming changes in 1.20, does this PR still add value?

dnnrly avatar Jan 23 '23 21:01 dnnrly

Given the upcoming changes in 1.20

Not that I'm aware of, what specific changes are you thinking of?

brianstrauch avatar Jan 23 '23 21:01 brianstrauch

I was thinking of the ability to create a version of your build with coverage profiling: https://go.dev/testing/coverage/

dnnrly avatar Jan 23 '23 21:01 dnnrly