shopware-bootstrap-theme icon indicating copy to clipboard operation
shopware-bootstrap-theme copied to clipboard
verified publisher icon conexco

Reflect latest SW updates (latest: 5.6.4)

Open thomasfrobieter opened this issue 6 years ago • 7 comments

Fixes https://github.com/conexco/shopware-bootstrap-theme/issues/33

thomasfrobieter avatar May 09 '19 08:05 thomasfrobieter

thank you @thomasfrobieter! Looks good to me. @benjamin-ott will have a look too.

Is this a Shopware 5.5 related Fix?

uehler avatar May 09 '19 10:05 uehler

Is this a Shopware 5.5 related Fix?

Not sure. I've just grabbed it from the bare theme, because we missed the option since we switched to the Bootstrap theme.

thomasfrobieter avatar May 22 '19 12:05 thomasfrobieter

Well done, confirming fixes!

JPustkuchen avatar May 23 '19 13:05 JPustkuchen

We're using it with 5.5.8!

JPustkuchen avatar May 23 '19 13:05 JPustkuchen

@thomasfrobieter: Please Update the title to "Reflect latest SW updates (latest: 5.6.4)" because this pull request references a branch which exactly does that.

JPustkuchen avatar Jan 16 '20 10:01 JPustkuchen

Hey @thomasfrobieter

thank you for your PR and sorry for the big delay. Your pull requests contains a lot of unrelated changes, could you fix that please?

and please target the dev branch, which will be merged into the 2.0 branch soon.

uehler avatar Jul 10 '20 06:07 uehler

Same reason as written in my other comment. We made a mistake and didn't create a separate branch for each fix so that the pull requests contain merged changes from the referenced issues.

Most simple solution would be to review and apply the latest commit to that branch which contains all changes from different issues then. Otherwise someone would have to split the single commits into separate branches and connect them to their issues, which is also not too hard.

JPustkuchen avatar Jul 28 '20 06:07 JPustkuchen