Full computer access

[a-rekkusu]

Hi there, on installation there is a prompt that states the add on will require full access to the PC. Why is this necessary? Other themes do not have this prompt. Thank you.

[conema]

Hi @a-rekkusu, I'm not sure because Thunderbird is asking for full access, since the only permission that I'm using is the storage one (for storing theme settings): https://github.com/conema/monterail-dark/blob/41b2c723d20ff60acf9899786cd4dd4e99ab1176/manifest.json#L36

I feel like that the full permission prompt is asked because I'm using the (official) experimental TB API, which is needed since the MailExtension APIs haven't the same expressivity as the old overlay addons. https://github.com/conema/monterail-dark/blob/41b2c723d20ff60acf9899786cd4dd4e99ab1176/manifest.json#L17-L26

I understand you concern, I just wrote a message in the thundebird add-ons developers chat to understand why the prompt is asking for full permission, in the meanwhile, if you want, you can see that the only JS files (https://github.com/conema/monterail-dark/tree/master/content/scripts) that I'm using are injecting the CSS files or are used for saving the settings of the settings page.

I will update you as soon as possible.

[conema]

I confirm that my feeling was right, it's because I'm using the experimental API.

From here: https://matrix.to/#/!IfvTkjNTPAqwpygthx:mozilla.org/$OUYRj8U95VDsizlp6_BxMTJwUhizGjx3-FX0S5gKhb4?via=mozilla.org&via=matrix.org&via=privacytools.io

I need to correct myself since it seems that the last MailExtensions APIs also supports some features that were needed for full themes, thus the theme could be rewritten as MailExtensions and the full permission prompt would go away.

At the moment I haven't a plan to do this theme rewrite as proper MailExtension, but I'll try do it it within the year. In the meantime, I will try to remove the WindowListener dependecy, which will at least remove the full permission prompt and display only the used permissions.

[a-rekkusu]

Thanks a lot for the quick clarification. I'm looking forward to those dependencies being removed. It's quite intimidating for more privacy conscious users, of course.

[conema]

Hi @a-rekkusu, Sorry for the late update. I was starting the rewriting of the theme, but some selectors (e.g. -moz-tree-row) are still unsupported in the new API. So, for now, the theme need to still use the WindowListener api.