kafka-security-manager icon indicating copy to clipboard operation
kafka-security-manager copied to clipboard

YAML support, Directory Support and compound syntax

Open ntrp opened this issue 5 years ago • 3 comments

Hi, as part of a project we implemented support for YAML format and multi-file support. The YAML support allows to write a more human readable permission config:

users:
  C=DE,O=org,OU=WEB,CN=t1.example.com,L=Stuttgart,ST=reg:
    topics:
      Topic1:
       - Read
      TopicPref_*:
        - All
    groups:
      team1-app1-*:
        - Read
        - Describe

In the YAML example you can also see the compound syntax where you define All to give all permissions on a topic.

The multi-file support allows to organize the permissions in different files to make separation of concerns more easy.

The implementation was done around version 0.5 so I would need to invest some time to create a valid pull request, are you interested in merging this kind of features? Otherwise I will spare the time ^^'

ntrp avatar Feb 06 '20 20:02 ntrp

Absolutely! Thanks so much for the amazing contribution, I'm so happy

I don't think it'll be too hard to adapt the code

Looking forward to the PR

On Thu, Feb 6 2020 at 9:01 PM, Ivan Gregurić Ortolan < [email protected] > wrote:

Hi, as part of a project we implemented support for YAML format and multi-file support. The YAML support allows to write a more human readable permission config:

users: C=DE,O=org,OU=WEB,CN=t1.example.com,L=Stuttgart,ST=reg: topics: Topic1: - Read TopicPref_: - All groups: team1-app1-: - Read - Describe

In the YAML example you can also see the compound syntax where you define All to give all permissions on a topic.

The multi-file support allows to organize the permissions in different files to make separation of concerns more easy.

The implementation was done around version 0.5 so I would need to invest some time to create a valid pull request, are you interested in merging this kind of features? Otherwise I will spare the time ^^'

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub ( https://github.com/simplesteph/kafka-security-manager/issues/71?email_source=notifications&email_token=AE7CW2L2UZS6V7GXFY7VQW3RBRUAHA5CNFSM4KRDCPV2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ILTZ5VQ ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AE7CW2MUVUMKUBUIYRCU4FLRBRUAHANCNFSM4KRDCPVQ ).

simplesteph avatar Feb 06 '20 20:02 simplesteph

Ok then I will try to see first how much effort is to try merging back our fork and then decide if it makes more sense just to re-implement the changes. Can't promise on the timing though since I don't have that much currently, hopefully in the next two weeks..

ntrp avatar Feb 06 '20 20:02 ntrp

Take your time :)

On Thu, Feb 6 2020 at 9:13 PM, Ivan Gregurić Ortolan < [email protected] > wrote:

Ok then I will try to see first how much effort is to try merging back our fork and then decide if it makes more sense just to re-implement the changes. Can't promise on the timing though since I don't have that much currently, hopefully in the next two weeks..

— You are receiving this because you commented. Reply to this email directly, view it on GitHub ( https://github.com/simplesteph/kafka-security-manager/issues/71?email_source=notifications&email_token=AE7CW2JXUJ735NNGAX5KKMTRBRVQDA5CNFSM4KRDCPV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELATVFQ#issuecomment-583088790 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AE7CW2NM7NKBP2SMIJXETLLRBRVQDANCNFSM4KRDCPVQ ).

simplesteph avatar Feb 06 '20 20:02 simplesteph