conduition
conduition
Hi @Kixunil and @romanz, sorry it's been a while since I fixed conflicts on this PR. I've been using the `pushtx` options from this PR on my own electrs node...
One minor annoyance is that the `pushtx` crate v0.4.0 relies on `[email protected]` whereas electrs uses `[email protected]`. Please let me know if that is a problem and I'll file a PR...
Fixed an infinite loop bug. Tests now pass on my machine
Correction: a couple of tests are still failing. `test_pay_invoice_internal` fails with: ``` wallet = @pytest.mark.asyncio @pytest.mark.skipif(is_regtest, reason="only works with FakeWallet") async def test_pay_invoice_internal(wallet: LightningWallet): # fill wallet invoice = await...
@lollerfirst Thank you massively for putting so much effort into this. I can see this PR is still in draft state, and you're on a roll, so i'll try not...
I just submitted a small refactor request here: https://github.com/lollerfirst/nutshell/pull/1
@lollerfirst I updated https://github.com/cashubtc/nuts/pull/128: https://github.com/cashubtc/nuts/pull/128#issuecomment-2267627657
I pushed a few PRs up with some suggested fixes: - https://github.com/lollerfirst/nutshell/pull/2 - https://github.com/lollerfirst/nutshell/pull/3 - https://github.com/lollerfirst/nutshell/pull/4
Well that sucks.
This PR clearly needs to be resynced with `main`, I will have a go at that soon after conferring with my clients