pycosat icon indicating copy to clipboard operation
pycosat copied to clipboard

picosat.c build error

Open ThePrez opened this issue 5 years ago • 2 comments

picosat.c has #include <sys/unistd.h> but on some systems it should just be #include <unistd.h>

The build error on IBM i is manifested as:

    In file included from pycosat.c:19:0:
    picosat.c:8150:24: fatal error: sys/unistd.h: No such file or directory
     #include <sys/unistd.h>
                            ^

To solve my immediate concern, one could simply #ifdef __PASE__ (defined on IBM i), but I am opening an issue rather than a PR so the project owners can choose their preferred way to address.

Thanks!

ThePrez avatar Jun 27 '19 20:06 ThePrez

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include: - What OS and version you reproduced the issue on - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

github-actions[bot] avatar Mar 15 '22 04:03 github-actions[bot]

I was able to include just unistd.h on osx

#include <unistd.h>

int main(int argc, char **argv) {
    return 0;
}

dholth avatar Oct 18 '23 19:10 dholth